There is no way the things you mentioned makes up for these tax gifts, police on gamedays and other freebies by the local government. We are talking millions of dollars each year here. Also, I am no tax attorney (thank God) but I believe the players and other employees of the Bills pay NYS tax only for the time they are living in NYS. At least that's what it was for me when I was splitting time among two states. Not sure how many have residence in other states for the off season.
People like to make arguments that Sports teams are a net positive to a regions bottom line. Unfortunately that generally does not seem to be the case. Sports teams may very well increase the quality of life for those who enjoy that particular sport (generally a small minority of the population) but a economic positive, nah (except for the businesses right around the stadium ... again, a drop in the bucket compared to the entire local economy).
However, it may be true in Canada where governments do not subsidize sports teams at all from what I hear.
I would prefer the Bills to stay put. But trying to argue a fiscal calamity if they leave makes me giggle
Here is a dated but interesting read on the topic.