Well McCain was instrumental in spreading the fake Steele dossier so I understand why Trump despised him.
Politically Trump definitely should have found ways to attack other than on his military record, but then again when McCain chose to circulate a completely fabricated pee tape dossier I'm sure that's exactly the type of response he expected and hoped for from Trump.